Adds custom resource for installing Consul. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 16, 2016 21:07
These custom resources move the logic of managing the system's Consul installation separate from the custom resource for managing the service.
I am deferring the management of TLS certificates to wrapper cookbooks. This closes #247.
johnbellone
added a commit
that referenced
this pull request
Mar 17, 2016
Adds custom resource for installing Consul.
|
@johnbellone Thank you very much for this PR. It is really a big deal! 👍 But I've noticed that you've removed symlink creation ( |
|
@legal90 I believe it may be because it's tricky to orchestrate a symlink across providers, when not all platforms would use/need it (looking at you Windows). My guess is that @johnbellone decided to forgo the management of it as it's only referenced in the service script, and that will get updated automatically. |
|
That being said, we should probably remove this default value: |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @acaiafa @sh9189
Closes #251
Closes #247